| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 May 2013 16:33:01 -0500 From: H Hartley Sweeten <hartleys@...ionengravers.com> To: Geert Uytterhoeven <geert@...ux-m68k.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ian Abbott <abbotti@....co.uk> Subject: RE: [PATCH 12/12] staging: COMEDI should depend on HAS_DMA On Thursday, May 09, 2013 2:05 PM, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "dma_free_coherent" [drivers/staging/comedi/comedi.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/staging/comedi/comedi.ko] undefined! > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> > Cc: Ian Abbott <abbotti@....co.uk> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: devel@...verdev.osuosl.org Grr.. The error appears to be caused by the dma alloc/free in comedi_buf.c. These only happen if the (s->async_dma_dir != DMA_NONE). The comedi core defaults the async_dma_dir to DMA_NONE. The only comedi drivers that set it are ni_660x, ni_mio_common, and ni_pcidio. The mite driver also has a dma_alloc/free. Ian, can you think of a better solution than just making comedi depend on HAS_DMA? Thanks, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists