linux-kernel - [Patch] quota: do not leak info to user-space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 May 2013 17:24:33 +0800
From:	Cong Wang <amwang@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
	Cong Wang <amwang@...hat.com>
Subject: [Patch] quota: do not leak info to user-space

From: Cong Wang <amwang@...hat.com>

There is a hole in struct fs_quota_stat, so we have to
zero the struct on stack before copying it to user-space.

Cc: Jan Kara <jack@...e.cz>
Signed-off-by: Cong Wang <amwang@...hat.com>

---
diff --git a/fs/quota/quota.c b/fs/quota/quota.c
index c7314f1..2b0c182 100644
--- a/fs/quota/quota.c
+++ b/fs/quota/quota.c
@@ -211,6 +211,7 @@ static int quota_getxstate(struct super_block *sb, void __user *addr)
 
 	if (!sb->s_qcop->get_xstate)
 		return -ENOSYS;
+	memset(&fqs, 0, sizeof(fqs));
 	ret = sb->s_qcop->get_xstate(sb, &fqs);
 	if (!ret && copy_to_user(addr, &fqs, sizeof(fqs)))
 		return -EFAULT;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/