linux-kernel - Re: [PATCH 2/9] perf tools: Add precise object to interface sysfs precise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bo8j7h3a.fsf@sejong.aot.lge.com>
Date:	Fri, 10 May 2013 10:34:49 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Andi Kleen <ak@...ux.intel.com>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 2/9] perf tools: Add precise object to interface sysfs precise

Hi Jiri,

On Thu,  9 May 2013 15:32:17 +0200, Jiri Olsa wrote:
> Adding precise util object to get maximum value for
> perf_event_attr::precise_ip. The value is exported
> via sysfs file '/sys/devices/cpu/precise'.
>
> The interface is:
>   int perf_precise__get(void)

I think Arnaldo wants to use double underscores to separate the name of
data struct and method name.  So wouldn't it be more appropriate using
one of perf_precise_get() or perf_get_precise()?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/