linux-kernel - Re: [PATCH 04/13] perf session: export a few functions for event processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130510121459.GH1040@krava.brq.redhat.com>
Date:	Fri, 10 May 2013 14:14:59 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	David Ahern <dsahern@...il.com>
Cc:	linux-kernel@...r.kernel.org, acme@...stprotocols.net,
	mingo@...nel.org, fweisbec@...il.com, peterz@...radead.org,
	namhyung@...nel.org, xiaoguangrong@...ux.vnet.ibm.com
Subject: Re: [PATCH 04/13] perf session: export a few functions for event
 processing

On Wed, May 08, 2013 at 10:31:40PM -0600, David Ahern wrote:
> Allows kvm live mode to reuse the event processing and ordered samples
> processing used by the perf-report path.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
> ---
>  tools/perf/util/session.c |   14 +++++++-------
>  tools/perf/util/session.h |    9 +++++++++
>  2 files changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 7e2c4c7..355b01f 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -248,7 +248,7 @@ static int process_finished_round(struct perf_tool *tool,
>  				  union perf_event *event,
>  				  struct perf_session *session);
>  
> -static void perf_tool__fill_defaults(struct perf_tool *tool)
> +void perf_tool__fill_defaults(struct perf_tool *tool)
>  {
>  	if (tool->sample == NULL)
>  		tool->sample = process_event_sample_stub;
> @@ -494,8 +494,8 @@ static int perf_session_deliver_event(struct perf_session *session,
>  				      struct perf_tool *tool,
>  				      u64 file_offset);
>  
> -static int flush_sample_queue(struct perf_session *s,
> -			       struct perf_tool *tool)
> +int flush_sample_queue(struct perf_session *s,
> +		       struct perf_tool *tool)

hm, can't see flush_sample_queue being used globaly

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/