| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 May 2013 08:53:57 -0400 From: Mike Snitzer <snitzer@...hat.com> To: Joe Thornber <thornber@...hat.com> Cc: "Darrick J. Wong" <darrick.wong@...cle.com>, device-mapper development <dm-devel@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] dmcache: flush superblock stats when retrieving status info On Fri, May 10 2013 at 6:10am -0400, Joe Thornber <thornber@...hat.com> wrote: > On Thu, May 09, 2013 at 01:44:38PM -0700, Darrick J. Wong wrote: > > When userspace queries dmcache for stats info, we should ensure that all the > > metadata gets flushed out of memory to disk. The current code neglects to > > update the disk copy of the hit/miss counters. > > Nack, I'm afraid. The commit is there purely to make sure the free > metadata blocks reported from the status are as high as possible. > [When a transaction is open we have to treat all blocks from the > previous transaction as allocated to allow rollback.] Right the commit is about presenting a more accurate status. Darrick's patch doesn't change what is reported for hit/miss counts (they are reported from in-core counters already, so accuracy isn't a concern). So I agree with what you're saying. Thanks Joe. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists