linux-kernel - Re: [RFC 30/42] drivers/usb/host: don't check resource with devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1305100957320.1313-100000@iolanthe.rowland.org>
Date:	Fri, 10 May 2013 10:03:28 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Wolfram Sang <wsa@...-dreams.de>
cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [RFC 30/42] drivers/usb/host: don't check resource with
 devm_ioremap_resource

On Fri, 10 May 2013, Wolfram Sang wrote:

> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
> 
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> ---
>  drivers/usb/host/ehci-atmel.c    |    9 +--------
>  drivers/usb/host/ehci-mxc.c      |    8 +-------
>  drivers/usb/host/ehci-platform.c |    6 +-----
>  drivers/usb/host/ehci-sh.c       |   10 +---------
>  drivers/usb/host/ohci-nxp.c      |    6 ------
>  drivers/usb/host/ohci-platform.c |    7 +------
>  6 files changed, 5 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
> index 6642009..62bf3e6 100644
> --- a/drivers/usb/host/ehci-atmel.c
> +++ b/drivers/usb/host/ehci-atmel.c
> @@ -101,17 +101,10 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
>  		goto fail_create_hcd;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(&pdev->dev,
> -			"Found HC with no register addr. Check %s setup!\n",
> -			dev_name(&pdev->dev));
> -		retval = -ENODEV;
> -		goto fail_request_resource;
> -	}
>  	hcd->rsrc_start = res->start;
>  	hcd->rsrc_len = resource_size(res);
>  
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	hcd->regs = devm_ioremap_resource(&pdev->dev, res);

This isn't right.  You are now dereferencing an uninitialized pointer
in the assignment to hcd->rsrc_start.  The compiler won't like that.

Most of the other changes in this patch suffer from the same problem.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/