linux-kernel - Re: [PATCH 3/3] init/Kconfig: Add option to set modprobe command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130510173511.GA28490@redhat.com>
Date:	Fri, 10 May 2013 19:35:11 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Lucas De Marchi <lucas.de.marchi@...il.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 3/3] init/Kconfig: Add option to set modprobe command

On 05/10, Oleg Nesterov wrote:
>
> On 05/10, Lucas De Marchi wrote:
> >
> > but I think it's a good tradeoff and covers other use cases as you
> > pointed out as well.
>
> OK, good.

Yes, perhaps this makes sense anyway but...

> > Ok. I'll give it a try.
>
> Please wait a bit, I'll send v2. See below.

Cough, wait ;)

Why do we need theese changes ????

> > > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe";
> > > +char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --";
>
> No. This is incompatible change, we shouldn't do this.

Exactly. This can break a distro which writes to sys/kernel/modprobe.

And if we do not do this, you can simply make a single trivial patch
which does

	-	char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe";
	+	char modprobe_path[KMOD_PATH_LEN] = CONFIG_DEFAULT_MODULE_LOAD_BIN;

that it all. (or perhaps a kernel parameter makes more sense).

Yes, this doesn't allow to pass the additional arguments, but is it
that important?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/