linux-kernel - Re: [PATCH v3 04/10] Revert "usb: phy: tegra: don't call into tegra-ehci directly"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1305101402220.1313-100000@iolanthe.rowland.org>
Date:	Fri, 10 May 2013 14:05:30 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	BVG Rao <venubyravarasu@...il.com>
cc:	gregkh@...uxfoundation.org, <swarren@...dotorg.org>,
	<balbi@...com>, Venu Byravarasu <vbyravarasu@...dia.com>,
	<linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH v3 04/10] Revert "usb: phy: tegra: don't call into
 tegra-ehci directly"

On Fri, 10 May 2013, BVG Rao wrote:

> On 10 May 2013 19:56, "Alan Stern" <stern@...land.harvard.edu> wrote:
> >
> > On Fri, 10 May 2013, Venu Byravarasu wrote:
> >
> > > This reverts commit ee5d5499edb94cd03738a52a7e234b139da8fd72.
> > >
> > > Signed-off-by: Venu Byravarasu <vbyravarasu@...dia.com>
> > > ---
> > > As PHY is being registered as separate driver, solution proposed with
> > > this patch cannot work anymore.
> > > Hence pushed patch 10 of this series to address the issue.
> >
> > You can't just revert a change like this -- doing so will recreate the
> > original problem that ee5d5499ed was meant to fix.
> >
> > You have to fix the problem _first_.  Then you can revert that commit.
> 
> Hi Alan,
> 
> I addressed that as part of patch 10 of the series.

I know -- that's what I was complaining about.  Patch 4 reverts the old
fix, and the new fix isn't added until patch 10.  So anybody who builds
a kernel using only patches 1 - 5 (for example) will end up with a
broken system.  This can easily happen during bisection testing.

You need to add the new fix either before or in the same patch as where 
the old fix is reverted.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/