linux-kernel - Re: linux-next: build warning after merge of the origintree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130510045144.GJ25399@ZenIV.linux.org.uk>
Date:	Fri, 10 May 2013 05:51:44 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kent Overstreet <koverstreet@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus <torvalds@...ux-foundation.org>
Subject: Re: linux-next: build warning after merge of the origintree

On Fri, May 10, 2013 at 01:19:26PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the akpm tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/md/bcache/super.c:656:2: warning: initialization from incompatible pointer type [enabled by default]
> drivers/md/bcache/super.c:656:2: warning: (near initialization for 'bcache_ops.release') [enabled by default]
> 
> Introduced by commit cafe56359144 ("bcache: A block layer cache")
> interacting with commit db2a144bedd5 ("block_device_operations->release()
> should return void").

Simply drop that return 0; and make it return void.  Or just leave it as is
for now - while C implementation has every right to blow up when calling a
function that returns int as if it had been a function returning void (e.g.
C ABI might have return value for int passed as it's usually done for big
structs), AFAIK, none of the architectures we support do anything of that
kind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/