linux-kernel - Re: [RFC] next cycle fun: ->release() API change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 May 2013 18:22:42 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] next cycle fun: ->release() API change

On Sat, May 11, 2013 at 10:05:05AM -0700, Linus Torvalds wrote:

> Ugh. You know what? I'd almost prefer to just do it as a single big
> commit, *without* the extra churn of then also renaming things.
> Because the renaming will just be painful and result in *more*
> problems, and quite frankly, this particular ABI change is "benign" in
> the sense that unconverted drivers will just cause warnings - the code
> will still compile (module -Werror, of course, which some
> architectures use) and still work perfectly fine (modulo crazy C paper
> standard issues that have nothing to do with actual reality).
> 
> In fact, the "it still works fine, just complains" makes it perfecly
> reasonable to even split it up into multiple independent commits. So
> rather than do the stupid renaming, I'd be perfectly happy with one
> commit that just changes "int ("release)(..)" to "void (*release)(..)"
> and then a boatload of "remove return value from release in
> drivers/block/*" kind of commits that do the conversion.
> 
> Because renaming really doesn't buy us anything but pain.

Umm...  I'd rather go the whole way and get rid of inode argument as well,
while we are at it.  It's completely redundant and it's unused in very large
majority of the instances.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/