[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <002601ce4e06$7f68fbc0$7e3af340$@samsung.com>
Date: Sat, 11 May 2013 14:15:05 +0900
From: Jingoo Han <jg1.han@...sung.com>
To: 'Wolfram Sang' <wsa@...-dreams.de>, linux-kernel@...r.kernel.org
Cc: 'Ben Dooks' <ben-linux@...ff.org>,
'Kukjin Kim' <kgene.kim@...sung.com>,
'Russell King' <linux@....linux.org.uk>,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>
Subject: Re: [RFC 39/42] arch/arm/plat-samsung: don't check resource with
devm_ioremap_resource
On Friday, May 10, 2013 5:17 PM, Wolfram Sang wrote:
>
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
Reviewed-by: Jingoo Han <jg1.han@...sung.com>
Best regards,
Jingoo Han
> ---
> arch/arm/plat-samsung/adc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c
> index ca07cb1..79690f2 100644
> --- a/arch/arm/plat-samsung/adc.c
> +++ b/arch/arm/plat-samsung/adc.c
> @@ -381,11 +381,6 @@ static int s3c_adc_probe(struct platform_device *pdev)
> }
>
> regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!regs) {
> - dev_err(dev, "failed to find registers\n");
> - return -ENXIO;
> - }
> -
> adc->regs = devm_ioremap_resource(dev, regs);
> if (IS_ERR(adc->regs))
> return PTR_ERR(adc->regs);
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists