lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130512153312.GA32210@kroah.com>
Date:	Sun, 12 May 2013 08:33:12 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Matt Kilgore <mattkilgore12@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: fixed coding style issues

On Sun, Apr 28, 2013 at 09:31:33PM -0400, Matt Kilgore wrote:
> From: Matt Kilgore <MattKilgore12@...il.com>
> 
> Fixed coding style issues with comments, braces, and spacing.
> 
> Signed-off-by: Matt Kilgore <mattkilgore12@...il.com>
> ---
>  drivers/staging/rtl8187se/r8180.h | 657 +++++++++++++++++++-------------------
>  1 file changed, 325 insertions(+), 332 deletions(-)

That's a lot of changes all in one patch, making it hard to review.
Care to break this up into "only do one thing" per patch and resend it?
Probably as a few patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ