linux-kernel - Re: [PATCH] mtd: fsmc_nand: fix error return code in fsmc_nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKohponMh0-L-LAYE7Rf3frULQ3WEwJCi+Hfe9qtE+zEWtncrQ@mail.gmail.com>
Date:	Mon, 13 May 2013 13:28:39 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	dwmw2@...radead.org, grant.likely@...aro.org,
	rob.herring@...xeda.com, artem.bityutskiy@...ux.intel.com,
	linus.walleij@...aro.org, vipin.kumar@...com,
	yongjun_wei@...ndmicro.com.cn, linux-mtd@...ts.infradead.org,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: fsmc_nand: fix error return code in fsmc_nand_probe()

On 13 May 2013 12:25, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Fix to return -ENODEV in the dma channel request error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/mtd/nand/fsmc_nand.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
> index 911e243..6988fc8 100644
> --- a/drivers/mtd/nand/fsmc_nand.c
> +++ b/drivers/mtd/nand/fsmc_nand.c
> @@ -1032,6 +1032,7 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
>         case USE_DMA_ACCESS:
>                 dma_cap_zero(mask);
>                 dma_cap_set(DMA_MEMCPY, mask);
> +               ret = -ENODEV;
>                 host->read_dma_chan = dma_request_channel(mask, filter,
>                                 pdata->read_dma_priv);
>                 if (!host->read_dma_chan) {
>

Better do it for error cases only.. like:

>                 if (!host->read_dma_chan) {
                           ret = -ENODEV;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/