linux-kernel - Re: [PATCH] staging: vme: fix error return code in vme_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5190A140.3020306@ge.com>
Date:	Mon, 13 May 2013 09:16:00 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	manohar.vanga@...il.com, gregkh@...uxfoundation.org,
	wfp5p@...ginia.edu, yamanetoshi@...il.com, gmate.amit@...il.com,
	joe@...ches.com, yongjun_wei@...ndmicro.com.cn,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vme: fix error return code in vme_user_probe()

On 13/05/13 07:05, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix to return -ENOMEM in the resource alloc error handling
> case instead of 0, as done elsewhere in this function.
> 

Hi Wei,

Thanks for your patch. As this is resource allocation rather than memory
allocation that is failing, would -EAGAIN not make more sense than -ENOMEM?

Martyn

> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/staging/vme/devices/vme_user.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index da7f759..5fe224d3 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -734,6 +734,7 @@ static int vme_user_probe(struct vme_dev *vdev)
>  		if (image[i].resource == NULL) {
>  			dev_warn(&vdev->dev,
>  				 "Unable to allocate slave resource\n");
> +			err = -ENOMEM;
>  			goto err_slave;
>  		}
>  		image[i].size_buf = PCI_BUF_SIZE;
> @@ -760,6 +761,7 @@ static int vme_user_probe(struct vme_dev *vdev)
>  		if (image[i].resource == NULL) {
>  			dev_warn(&vdev->dev,
>  				 "Unable to allocate master resource\n");
> +			err = -ENOMEM;
>  			goto err_master;
>  		}
>  		image[i].size_buf = PCI_BUF_SIZE;
> 


-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@...com                  | VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/