linux-kernel - Re: [PATCH V4 2/3] pwm: pxa: use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMPhdO-66YfMuzSbdbDoi3OjBzN9yqw7jGQ8Hk8dGRJNNLAsXA@mail.gmail.com>
Date:	Mon, 13 May 2013 10:08:17 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Chao Xie <chao.xie@...vell.com>
Cc:	Thierry Reding <thierry.reding@...onic-design.de>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Chao Xie <xiechao.mail@...il.com>
Subject: Re: [PATCH V4 2/3] pwm: pxa: use module_platform_driver()

On Mon, May 6, 2013 at 9:30 AM, Chao Xie <chao.xie@...vell.com> wrote:
> Old pwm-pxa.c will register driver by arch_initcall. Then other
> drivers based on the PWM driver can successully call old
> pwm_request because arch_initcall make sure the PWM driver will
> be registered earlier.
> Now, pwm_request is re-written and done by common layer code. It
> will return -EPROBE_DEFER if the PWM device is not probed.
> The driver based on PWM driver can make use of -EPROBE_DEFER
> to delay its probing.
> So arch_initcall can be replaced by module_platform_driver.
>
> Signed-off-by: Chao Xie <chao.xie@...vell.com>

Looks good to me,

Acked-by: Eric Miao <eric.y.miao@...il.com>

> ---
>  drivers/pwm/pwm-pxa.c |   12 +-----------
>  1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
> index dee6ab55..aa4bea7 100644
> --- a/drivers/pwm/pwm-pxa.c
> +++ b/drivers/pwm/pwm-pxa.c
> @@ -187,16 +187,6 @@ static struct platform_driver pwm_driver = {
>         .id_table       = pwm_id_table,
>  };
>
> -static int __init pwm_init(void)
> -{
> -       return platform_driver_register(&pwm_driver);
> -}
> -arch_initcall(pwm_init);
> -
> -static void __exit pwm_exit(void)
> -{
> -       platform_driver_unregister(&pwm_driver);
> -}
> -module_exit(pwm_exit);
> +module_platform_driver(pwm_driver);
>
>  MODULE_LICENSE("GPL v2");
> --
> 1.7.4.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/