linux-kernel - Re: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87obcfqldw.fsf@devron.myhome.or.jp>
Date:	Mon, 13 May 2013 18:28:27 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Gu Zheng <guz.fnst@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()

Gu Zheng <guz.fnst@...fujitsu.com> writes:

>>>From 87141ec058aad35ac55bc7c3fc2eb378566a5a6a Mon Sep 17 00:00:00 2001
> From: Gu Zheng <guz.fnst@...fujitsu.com>
> Date: Mon, 13 May 2013 17:48:19 +0900
> Subject: [PATCH] fs/fat: Use fat_msg() to replace printk() in __fat_fs_error()

> -		printk(KERN_ERR "FAT-fs (%s): error, %pV\n", sb->s_id, &vaf);
> +		fat_msg(sb, KERN_ERR, "error, %pV", &vaf);
>  		va_end(args);

I'm assuming nested "%pV" is works fine. If so,

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> @@ -38,8 +38,7 @@ void __fat_fs_error(struct super_block *sb, int report, const char *fmt, ...)
>  		panic("FAT-fs (%s): fs panic from previous error\n", sb->s_id);
>  	else if (opts->errors == FAT_ERRORS_RO && !(sb->s_flags & MS_RDONLY)) {
>  		sb->s_flags |= MS_RDONLY;
> -		printk(KERN_ERR "FAT-fs (%s): Filesystem has been "
> -				"set read-only\n", sb->s_id);
> +		fat_msg(sb, KERN_ERR, "Filesystem has been set read-only");
>  	}
>  }
>  EXPORT_SYMBOL_GPL(__fat_fs_error);

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/