linux-kernel - Re: [PATCH -next] ASoC: mid-x86: add missing iounmap() to probe error and remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130513134522.GH6836@sirena.org.uk>
Date:	Mon, 13 May 2013 17:45:22 +0400
From:	Mark Brown <broonie@...nel.org>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	wfp5p@...ginia.edu, vinod.koul@...ux.intel.com,
	ramesh.babu@...el.com, namartax.kohli@...el.com,
	yongjun_wei@...ndmicro.com.cn, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ASoC: mid-x86: add missing iounmap() to probe
 error and remove

On Mon, May 13, 2013 at 05:00:44PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Add the missing iounmap() before return from snd_mfld_mc_probe()
> in the error handling case and to snd_mfld_mc_remove().

A better approach to this sort of issue is to convert to devm_,
eliminating the possibility of such errors in the future.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)