linux-kernel - RE: [PATCH] NVMe: fix error return code in nvme_submit_bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <100D68C7BA14664A8938383216E40DE027F80EA1@fmsmsx111.amr.corp.intel.com>
Date:	Mon, 13 May 2013 13:51:37 +0000
From:	"Wilcox, Matthew R" <matthew.r.wilcox@...el.com>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	"Busch, Keith" <keith.busch@...el.com>,
	"Verma, Vishal L" <vishal.l.verma@...el.com>
CC:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] NVMe: fix error return code in nvme_submit_bio_queue()

I can't apply this patch.  Instead of following what it says in MAINTAINERS, you've sent it to my Exchange address.  And now it's all mangled.

NVM EXPRESS DRIVER
M:      Matthew Wilcox <willy@...ux.intel.com>
L:      linux-nvme@...ts.infradead.org

________________________________________
From: Wei Yongjun [weiyj.lk@...il.com]
Sent: May 12, 2013 7:30 PM
To: Wilcox, Matthew R; Busch, Keith; Verma, Vishal L
Cc: yongjun_wei@...ndmicro.com.cn; linux-kernel@...r.kernel.org
Subject: [PATCH] NVMe: fix error return code in nvme_submit_bio_queue()

From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Fix to return -ENOMEM in the nvem iod alloc error handling case instead
of 0(possible overwrite to 0 by above nvme_submit_flush_data()), as done
elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
---
 drivers/block/nvme-core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index 8efdfaa..750c337 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -629,7 +629,7 @@ static int nvme_submit_bio_queue(struct nvme_queue *nvmeq, struct nvme_ns *ns,
        struct nvme_command *cmnd;
        struct nvme_iod *iod;
        enum dma_data_direction dma_dir;
-       int cmdid, length, result = -ENOMEM;
+       int cmdid, length, result;
        u16 control;
        u32 dsmgmt;
        int psegs = bio_phys_segments(ns->queue, bio);
@@ -641,8 +641,10 @@ static int nvme_submit_bio_queue(struct nvme_queue *nvmeq, struct nvme_ns *ns,
        }

        iod = nvme_alloc_iod(psegs, bio->bi_size, GFP_ATOMIC);
-       if (!iod)
+       if (!iod) {
+               result = -ENOMEM;
                goto nomem;
+       }
        iod->private = bio;

        result = -EBUSY;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/