lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 May 2013 16:00:34 +0200 From: Takashi Iwai <tiwai@...e.de> To: Imre Deak <imre.deak@...el.com> Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Daniel Vetter <daniel.vetter@...ll.ch>, Clemens Ladisch <clemens@...isch.de>, Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org Subject: Re: [PATCH 11/11] sound/oxygen_io: take msecs_to_jiffies_min into use At Fri, 10 May 2013 15:13:29 +0300, Imre Deak wrote: > > Use msecs_to_jiffies_min instead of open-coding the same. > > Signed-off-by: Imre Deak <imre.deak@...el.com> > --- > sound/pci/oxygen/oxygen_io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/oxygen/oxygen_io.c b/sound/pci/oxygen/oxygen_io.c > index 521eae4..132ecbe 100644 > --- a/sound/pci/oxygen/oxygen_io.c > +++ b/sound/pci/oxygen/oxygen_io.c > @@ -108,7 +108,7 @@ static int oxygen_ac97_wait(struct oxygen *chip, unsigned int mask) > wait_event_timeout(chip->ac97_waitqueue, > ({ status |= oxygen_read8(chip, OXYGEN_AC97_INTERRUPT_STATUS); > status & mask; }), > - msecs_to_jiffies(1) + 1); > + msecs_to_jiffies_min(1)); This would change the behavior, I guess. (Though, I'm not sure whether the original code was intentional.) And, isn't msecs_to_jiffies_min(1) identical with msecs_to_jiffies(1)? thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists