linux-kernel - [RFC PATCH 0/2] return value from shrinkers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 May 2013 16:16:33 +0200
From:	Oskar Andero <oskar.andero@...ymobile.com>
To:	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
CC:	Hugh Dickins <hughd@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Radovan Lekanovic <radovan.lekanovic@...ymobile.com>,
	David Rientjes <rientjes@...gle.com>,
	Oskar Andero <oskar.andero@...ymobile.com>
Subject: [RFC PATCH 0/2] return value from shrinkers

Hi,

In a previous discussion on lkml it was noted that the shrinkers use the
magic value "-1" to signal that something went wrong.

This patch-set implements the suggestion of instead using errno.h values
to return something more meaningful.

The first patch simply changes the check from -1 to any negative value and
updates the comment accordingly.

The second patch updates the shrinkers to return an errno.h value instead
of -1. Since this one spans over many different areas I need input on what is
a meaningful return value. Right now I used -EBUSY on everything for consitency.

What do you say? Is this a good idea or does it make no sense at all?

Thanks!

-Oskar

Oskar Andero (2):
  mm: vmscan: let any negative return value from shrinker mean error
  Clean-up shrinker return values

 drivers/staging/android/ashmem.c     | 2 +-
 drivers/staging/zcache/zcache-main.c | 2 +-
 fs/gfs2/glock.c                      | 2 +-
 fs/gfs2/quota.c                      | 2 +-
 fs/nfs/dir.c                         | 2 +-
 fs/ubifs/shrinker.c                  | 2 +-
 include/linux/shrinker.h             | 5 +++--
 mm/vmscan.c                          | 2 +-
 net/sunrpc/auth.c                    | 2 +-
 9 files changed, 11 insertions(+), 10 deletions(-)

-- 
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/