linux-kernel - Re: [PATCH] module: Add section ".ref.data" into kmemleak-scan-area.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bo8f39di.fsf@rustcorp.com.au>
Date:	Mon, 13 May 2013 11:54:09 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	majianpeng <majianpeng@...il.com>
Cc:	Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH] module: Add section ".ref.data" into kmemleak-scan-area.

majianpeng <majianpeng@...il.com> writes:

> In commit 523c81135,it used "__refdata" on event_class_ftrace_##call.
> It will cause kmemleak to misjudge because when loading module it did
> not add '.ref.data' into kmemleak-scan-area.
> 
> Signed-off-by: Jianpeng Ma <majianpeng@...il.com>
> ---
>  kernel/module.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Catalin?

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Cheers,
Rusty.

> diff --git a/kernel/module.c b/kernel/module.c
> index b049939..dafe2ea 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2434,7 +2434,8 @@ static void kmemleak_load_module(const struct module *mod,
>                 const char *name = info->secstrings + info->sechdrs[i].sh_name;
>                 if (!(info->sechdrs[i].sh_flags & SHF_ALLOC))
>                         continue;
> -               if (!strstarts(name, ".data") && !strstarts(name, ".bss"))
> +               if (!strstarts(name, ".data") && !strstarts(name, ".bss") &&
> +                       !strstarts(name, ".ref.data"))
>                         continue;
>  
>                 kmemleak_scan_area((void *)info->sechdrs[i].sh_addr,
> -- 
> 1.7.10.4
>
>>>From 9adf5b9aae7ceb97828042d0ae8fe9fb688bc691 Mon Sep 17 00:00:00 2001
> From: Jianpeng Ma <majianpeng@...il.com>
> Date: Sat, 11 May 2013 10:04:14 +0800
> Subject: [PATCH] module: Add section ".ref.data" into kmemleak-scan-area.
>
> In commit 523c81135,it used "__refdata" on event_class_ftrace_##call.
> It will cause kmemleak to misjudge because when loading module it did
> not add '.ref.data' into kmemleak-scan-area.
>
> Signed-off-by: Jianpeng Ma <majianpeng@...il.com>
> ---
>  kernel/module.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index b049939..dafe2ea 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2434,7 +2434,8 @@ static void kmemleak_load_module(const struct module *mod,
>  		const char *name = info->secstrings + info->sechdrs[i].sh_name;
>  		if (!(info->sechdrs[i].sh_flags & SHF_ALLOC))
>  			continue;
> -		if (!strstarts(name, ".data") && !strstarts(name, ".bss"))
> +		if (!strstarts(name, ".data") && !strstarts(name, ".bss") && 
> +			!strstarts(name, ".ref.data"))
>  			continue;
>  
>  		kmemleak_scan_area((void *)info->sechdrs[i].sh_addr,
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/