linux-kernel - [PATCH] rtc: rtc-vr41xx: fix error return code in rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAPgLHd-+10_c9A64OW8QkjgGn+FjrpMQTH+C+Y-HN_fwgQSrKA@mail.gmail.com>
Date:	Mon, 13 May 2013 14:26:00 +0800
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	a.zummo@...ertech.it, akpm@...ux-foundation.org
Cc:	yongjun_wei@...ndmicro.com.cn, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] rtc: rtc-vr41xx: fix error return code in rtc_probe()

From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Fix to return -EBUSY in the platform irq get error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
---
 drivers/rtc/rtc-vr41xx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c
index 3b5b4fa..54e104e 100644
--- a/drivers/rtc/rtc-vr41xx.c
+++ b/drivers/rtc/rtc-vr41xx.c
@@ -339,8 +339,10 @@ static int rtc_probe(struct platform_device *pdev)
 		goto err_device_unregister;
 
 	pie_irq = platform_get_irq(pdev, 1);
-	if (pie_irq <= 0)
+	if (pie_irq <= 0) {
+		retval = -EBUSY;
 		goto err_free_irq;
+	}
 
 	retval = request_irq(pie_irq, rtclong1_interrupt, 0,
 			     "rtclong1", pdev);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/