linux-kernel - Re: [v3.10-rc1] WARNING: at kernel/rcutree.c:502

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ppwuroxb.fsf@nemi.mork.no>
Date:	Tue, 14 May 2013 09:38:56 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Cc:	paulmck@...ux.vnet.ibm.com, Dipankar Sarma <dipankar@...ibm.com>,
	linux-kernel@...r.kernel.org, rostedt@...dmis.org,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [v3.10-rc1] WARNING: at kernel/rcutree.c:502

"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com> writes:
> On 05/13/2013 08:09 PM, Bjørn Mork wrote:
>
>> Hey, hey, hey.  Turns out this wasn't that wrong after all.  That merge
>> includes a oneline diff in kernel/cpu/idle.c and it *is* actually this
>> diff which trigger the problem for me.  Reverting it, using the attached
>> patch, makes the warning go away.  Which means that it had nothing to do
>> with your RCU changes.
>> 
>> But I haven't the faintest idea how this is supposed to work, or even
>> how to explain the patch properly, so I think I need some help from
>> Thomas here.  Unless this makes you understand the real issue?
>> 
>> Thomas, why does powertop trigger the
>> 
>>   WARNING: at kernel/rcutree.c:502 rcu_eqs_exit_common.isra.48+0x3d/0x125()
>> 
>> without the attached patch?  And what is the proper resolution?
>> 
>  
> The problem appears to be in the cpu idle poll implementation. You can trigger
> this problem by passing idle=poll in the kernel cmd-line as well, right?

That sounded so obvious that it made me think "Doh, why didn't I just
test that before?"  But unfortunately there must be some other factor
involved. No warnings observed during normal use when running with
idle=poll:

 bjorn@...i:~$ dmesg|grep polling
 [    0.000000] process: using polling idle threads


I expected a flood of warnings here, but there is none until I start
powertop (to confirm that the original issue is still there).  So it's
more than just entering cpu_idle_poll().

> I think I understand what is going on here. Can you please try the fix below?
> (It is only compile-tested since its very late here and I really need to get
> some sleep!).

Works perfect.  Thanks.  I assume this is the correct fix even if the
problem isn't completely understood?



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/