linux-kernel - [Suggestion] kernel/irqdesc.c: not checking whether failure occurs for alloc_desc() in early_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <519215AC.4010109@asianux.com>
Date:	Tue, 14 May 2013 18:45:00 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [Suggestion] kernel/irqdesc.c: not checking whether failure occurs
 for alloc_desc() in early_irq_init().

Hello Maintainers:

For early_irq_init(), it may be failure (can return an error code), and
for alloc_desc(), also may return 'NULL' when '-ENOMEM'.

But it seems the authors are sure that early_irq_init() are always
success, is it correct ? (or early_irq_init() will never be used ?)

I think, it is better to also check alloc_desc() return value in
early_irq_init().

Please help check when you have time.

Thanks.
-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/