linux-kernel - Re: [PATCH] sched: remove redundant update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130514115200.GF15942@dyad.programming.kicks-ass.net>
Date:	Tue, 14 May 2013 13:52:00 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Neil Zhang <zhangwm@...vell.com>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: remove redundant update_runtime notifier

On Thu, Apr 11, 2013 at 09:04:59PM +0800, Neil Zhang wrote:
> migration_call() will do all the things that update_runtime() does.
> So let's remove it.
> 
> Furthermore, there is potential risk that the current code will catch
> BUG_ON at line 689 of rt.c when do cpu hotplug while there are realtime
> threads running because of enabling runtime twice while the rt_runtime
> may already changed.
> 

Indeed, it looks like the 'new' sched_class::rq_{on,off}line stuff handles all
that just fine.

Thanks for spotting that.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/