linux-kernel - Re: [PATCH 06/14] ARM: bcm281xx: Remove init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5192512C.6080006@broadcom.com>
Date:	Tue, 14 May 2013 07:58:52 -0700
From:	"Christian Daudt" <csd@...adcom.com>
To:	"Maxime Ripard" <maxime.ripard@...e-electrons.com>
cc:	"Michal Simek" <michal.simek@...inx.com>,
	"Linus Walleij" <linus.walleij@...aro.org>,
	"Jamie Iles" <jamie@...ieiles.com>,
	"Simon Horman" <horms@...ge.net.au>,
	"Magnus Damm" <magnus.damm@...il.com>,
	"Viresh Kumar" <viresh.kumar@...aro.org>,
	"David Brown" <davidb@...eaurora.org>,
	"Jason Cooper" <jason@...edaemon.net>,
	"Andrew Lunn" <andrew@...n.ch>,
	"Gregory Clement" <gregory.clement@...e-electrons.com>,
	"Shawn Guo" <shawn.guo@...aro.org>,
	"Barry Song" <baohua.song@....com>,
	"Tony Prisk" <linux@...sktech.co.nz>,
	linux-arm-kernel@...ts.infradead.org, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	"Arnd Bergmann" <arnd@...db.de>, "Olof Johansson" <olof@...om.net>
Subject: Re: [PATCH 06/14] ARM: bcm281xx: Remove init_irq declaration in
 machine description

On 13-05-14 01:25 AM, Maxime Ripard wrote:
> Hi Christian,
>
> Le 13/05/2013 22:06, Christian Daudt a écrit :
>> On 13-05-13 02:44 AM, Maxime Ripard wrote:
>>> Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is
>>> specified") removed the need to explictly setup the init_irq field in
>>> the machine description when using only irqchip_init. Remove that
>>> declaration for bcm281xx as well.
>>>
>>> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
>>> ---
>>>    arch/arm/mach-bcm/board_bcm.c | 1 -
>>>    1 file changed, 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-bcm/board_bcm.c
>>> b/arch/arm/mach-bcm/board_bcm.c
>>> index 22e8421..24556cf 100644
>>> --- a/arch/arm/mach-bcm/board_bcm.c
>>> +++ b/arch/arm/mach-bcm/board_bcm.c
>>> @@ -54,7 +54,6 @@ static void __init board_init(void)
>>>    static const char * const bcm11351_dt_compat[] = { "bcm,bcm11351",
>>> NULL, };
>>>      DT_MACHINE_START(BCM11351_DT, "Broadcom Application Processor")
>>> -    .init_irq = irqchip_init,
>>>        .init_time = clocksource_of_init,
>>>        .init_machine = board_init,
>>>        .dt_compat = bcm11351_dt_compat,
>> Acked-by: Christian Daudt <csd@...adcom.com>
> Thanks!
>
> I forgot to remove the include of irqchip.h into all these patches, so
> I'll send a v2, and I guess you could probably merge it through your
> tree after that directly.
Ok. will do.

  thanks,
    csd



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/