linux-kernel - Re: [PATCH] kernel/workqueue.c: kfree issue, need check flag 'WQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130514152046.GC6795@mtj.dyndns.org>
Date:	Tue, 14 May 2013 08:20:46 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/workqueue.c: kfree issue, need check flag
 'WQ_UNBOUND' when processing failure.

On Tue, May 14, 2013 at 09:06:40PM +0800, Chen Gang wrote:
>  err_destroy:
>  	destroy_workqueue(wq);
> +	if (flags & WQ_UNBOUND) {
> +err_free_wq:
> +		free_workqueue_attrs(wq->unbound_attrs);
> +		kfree(wq);
> +	}

Doesn't the above make the code free wq twice on after err_destroy?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/