linux-kernel - Re: [PATCH wq/for-3.10-fixes] workqueue: workqueue_congested() shouldn't translate WORK_CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130514153908.GE6795@mtj.dyndns.org>
Date:	Tue, 14 May 2013 08:39:08 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Dirk Gouders <dirk@...ders.net>
Cc:	linux-kernel@...r.kernel.org, Lai Jiangshan <laijs@...fujitsu.com>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH wq/for-3.10-fixes] workqueue: workqueue_congested()
 shouldn't translate WORK_CPU_UNBOUND into node number

On Tue, May 14, 2013 at 11:32:12AM +0200, Dirk Gouders wrote:
> Tejun Heo <tj@...nel.org> writes:
> 
> > From d3251859168b0b12841e1b90d6d768ab478dc23d Mon Sep 17 00:00:00 2001
> > From: Tejun Heo <tj@...nel.org>
> > Date: Fri, 10 May 2013 11:10:17 -0700
> >
> > df2d5ae499 ("workqueue: map an unbound workqueues to multiple per-node
> > pool_workqueues") made unbound workqueues to map to multiple per-node
> > pool_workqueues and accordingly updated workqueue_contested() so that,
> > for unbound workqueues, it maps the specified @cpu to the NUMA node
> > number to obtain the matching pool_workqueue to query the congested
> > state.
> >
> > Before this change, workqueue_congested() ignored @cpu for unbound
> > workqueues as there was only one pool_workqueue and some users
> > (fscache) called it with WORK_CPU_UNBOUND.  After the commit, this
> > causes the following oops as WORK_CPU_UNBOUND gets translated to
> > garbage by cpu_to_node().
> 
> I probably also noticed this problem with 3.10.0-rc1-00087-g674825d when
> I invoked init 0 (see attached oops).  I applied your patch and after
> that the problem has gone.

Thanks, sending the patch to Linus right now.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/