linux-kernel - Re: [PATCH 17/21] CRISv32: remove inline marking of EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130514163556.GR8853@axis.com>
Date:	Tue, 14 May 2013 18:35:57 +0200
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Denis Efremov <yefremov.denis@...il.com>
Cc:	Mikael Starvik <starvik@...s.com>,
	Jesper Nilsson <jespern@...s.com>,
	linux-cris-kernel <linux-cris-kernel@...s.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"trivial@...nel.org" <trivial@...nel.org>,
	"ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>
Subject: Re: [PATCH 17/21] CRISv32: remove inline marking of EXPORT_SYMBOL
 functions

On Thu, May 09, 2013 at 12:36:55PM +0200, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Denis Efremov <yefremov.denis@...il.com>

Yes, agreed.

Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

> ---
>  arch/cris/arch-v32/kernel/cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/cris/arch-v32/kernel/cache.c b/arch/cris/arch-v32/kernel/cache.c
> index f38433b..876be53 100644
> --- a/arch/cris/arch-v32/kernel/cache.c
> +++ b/arch/cris/arch-v32/kernel/cache.c
> @@ -5,7 +5,7 @@
>  
>  /* This file is used to workaround a cache bug, Guinness TR 106. */
>  
> -inline void flush_dma_descr(struct dma_descr_data *descr, int flush_buf)
> +void flush_dma_descr(struct dma_descr_data *descr, int flush_buf)
>  {
>  	/* Flush descriptor to make sure we get correct in_eop and after. */
>  	asm volatile ("ftagd [%0]" :: "r" (descr));
> -- 
> 1.8.1.4

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/