linux-kernel - [PATCH] x86, setup: Correct comment in reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5193AAFE.2010406@gmail.com>
Date:	Wed, 15 May 2013 23:34:22 +0800
From:	Zhang Yanfei <zhangyanfei.yes@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>, mingo@...hat.com,
	tglx@...utronix.de, Andrew Morton <akpm@...ux-foundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] x86, setup: Correct comment in reserve_crashkernel

From: Zhang Yanfei <zhangyanfei@...fujitsu.com>

One comment in reserve_crashkernel is out of date and incorrect.
So fix it.

Signed-off-by: Zhang Yanfei <zhangyanfei@...fujitsu.com>
---
 arch/x86/kernel/setup.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 56f7fcf..eba0d78 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -590,7 +590,12 @@ static void __init reserve_crashkernel(void)
 	/* 0 means: find the address automatically */
 	if (crash_base <= 0) {
 		/*
-		 *  kexec want bzImage is below CRASH_KERNEL_ADDR_MAX
+		 *  For x86_64, when crashkernel=X,high is not passed, kexec
+		 *  wants bzImage is below CRASH_KERNEL_ADDR_LOW_MAX.
+		 *  For x86_32, crashkernel=X,high is not supported by defining
+		 *  CRASH_KERNEL_ADDR_HIGH_MAX and CRASH_KERNEL_ADDR_LOW_MAX
+		 *  with the same limit and kexec always wants bzImage is below
+		 *  this limit due to mapping restrictions.
 		 */
 		crash_base = memblock_find_in_range(alignment,
 					high ? CRASH_KERNEL_ADDR_HIGH_MAX :
-- 
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/