linux-kernel - Re: [PATCH] vhost-scsi: Depend on NET for memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8761yk254u.fsf@rustcorp.com.au>
Date:	Wed, 15 May 2013 14:47:53 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Asias He <asias@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>
Cc:	Nicholas Bellinger <nab@...ux-iscsi.org>, kvm@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	target-devel@...r.kernel.org, Asias He <asias@...hat.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Randy Dunlap <rdunlap@...radead.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

Asias He <asias@...hat.com> writes:
> scsi.c includes vhost.c which uses memcpy_fromiovec.
>
> This patch fixes this build failure.
>
>    From Randy Dunlap:
>    '''
>    on x86_64:
>
>    ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined!
>
>    It needs to depend on NET since net/core/ provides that function.
>    '''

Proper fix please.

Though I can't see why you thought this was a good idea.  Nonetheless, I
shan't highlight why: I have far too much respect for your intellects
and abilities.

No, don't thank me!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/