linux-kernel - Re: [PATCH] ASoC: max98090: add digital mic mux to record path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAL1qeaEFsZmR5Cpe3GE8djBhEib585ni7hxs=FtjddRXKYENxg@mail.gmail.com>
Date:	Wed, 15 May 2013 23:43:03 -0700
From:	Andrew Bresticker <abrestic@...omium.org>
To:	Matthew Mowdy <Matthew.Mowdy@...imintegrated.com>
Cc:	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"broonie@...nel.org" <broonie@...nel.org>,
	"perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.de" <tiwai@...e.de>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Dylan Reid <dgreid@...omium.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ralph Birt <Ralph.Birt@...imintegrated.com>,
	Evan Ragsdale <Evan.Ragsdale@...imintegrated.com>
Subject: Re: [PATCH] ASoC: max98090: add digital mic mux to record path

Hi Matthew,

> Default Routing:
>
> Of note (software can confirm) I believe the default DAPM routing for the
> driver was intentional setup such that :
>
> Record:
>
> o   If a headset MIC is present, record from it.
>
> o   If not, digital MIC is the default record input.

While this may have been the intention, that's not what the driver is
currently doing.  This is how the capture route looks before this
patch:

HiFi Capture -> AIFOUT{L,R} -> LBEN{L,R}_MUX[0] -> DMIC{L,R}_ENA

So, since DMIC{L,R}_ENA are configured as supplies, they will always
be turned on during record when the loopback mux is set to 0 (i.e. no
loopback)  That's obviously wrong, so this patch changes the
DMIC{L,R}_ENA to muxes.

> The defaults can be modified by each end user as needed (for analog
> microphones, line inputs, etc.). Please insure any patch to the baseline
> driver reflects the correct operation of the digital microphone enable bits,
> and preserves the intended default operation.

Ok, I'll change it so that the DMIC{L,R} muxes aren't individually controllable.

Thanks,
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/