linux-kernel - Re: V3.10-rc1 memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130516101200.GA3001@darko.cambridge.arm.com>
Date:	Thu, 16 May 2013 11:12:00 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: V3.10-rc1 memory leak

On Wed, May 15, 2013 at 08:33:01PM +0100, Steven Rostedt wrote:
> On Wed, 2013-05-15 at 15:37 +0100, Catalin Marinas wrote:
> 
> > >From 0621c7e1909ea86bf8499a0ffe5ea59d1007ee8c Mon Sep 17 00:00:00 2001
> > From: Catalin Marinas <catalin.marinas@....com>
> > Date: Wed, 15 May 2013 15:30:46 +0100
> > Subject: [PATCH] kmemleak: Scan the jump label module section
> > 
> > Objects allocated in jump_label_add_module() are currently reported as
> > leaks, though the pointers are stored in the module jump label section.
> > This patch informs kmemleak that this section needs to be scanned.
> > 
> > Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> > Reported-by: Steven Rostedt <rostedt@...dmis.org>
> 
> This didn't work. I still get the leak messages. But this change did:
> 
> Instead of just picking data sections by name (names that start
> with .data, .bss or .ref.data), use the section flags and scan all
> sections that are allocated, writable and not executable. Which should
> cover all sections of a module that might reference data.
> 
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

That's even better. I tested the two patches as well, added a subject
and a bit of clean-up and pushed them to this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64.git kmemleak

Rusty, are you ok to take these or just ack and I'll push them to Linus.

Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/