[<prev] [next>] [day] [month] [year] [list]
Message-id: <17870889.122861368669248723.JavaMail.weblogic@epml12>
Date: Thu, 16 May 2013 01:54:11 +0000 (GMT)
From: ÇÑÁø±¸ <jg1.han@...sung.com>
To: Tomasz Figa <t.figa@...sung.com>,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>, akpm@...ux-foundation.org
Cc: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"a.zummo@...ertech.it" <a.zummo@...ertech.it>,
"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
½ÉÁØ¿µ <jy0922.shim@...sung.com>,
¹Ú°æ¹Î <kyungmin.park@...sung.com>,
jg1.han@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: max8998: Check for pdata presence before dereferencing
Thursday, May 16, 2013 12:16 AM, Tomasz Figa wrote:
>
> Currently the driver can crash with a NULL pointer dereference if no pdata
> is provided, despite of successful registration of MFD part. This patch
> fixes the problem by adding a NULL check before dereferencing the pdata
> pointer.
>
> Signed-off-by: Tomasz Figa <t.figa@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
CC'ed Andrew Morton
Reviewed-by: Jingoo Han <jg1.han@...sung.com>
Best regards,
Jingoo Han
> ---
> drivers/rtc/rtc-max8998.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-max8998.c b/drivers/rtc/rtc-max8998.c
> index 48b6612..d5af7ba 100644
> --- a/drivers/rtc/rtc-max8998.c
> +++ b/drivers/rtc/rtc-max8998.c
> @@ -285,7 +285,7 @@ static int max8998_rtc_probe(struct platform_device *pdev)
> info->irq, ret);
>
> dev_info(&pdev->dev, "RTC CHIP NAME: %s\n", pdev->id_entry->name);
> - if (pdata->rtc_delay) {
> + if (pdata && pdata->rtc_delay) {
> info->lp3974_bug_workaround = true;
> dev_warn(&pdev->dev, "LP3974 with RTC REGERR option."
> " RTC updates will be extremely slow.\n");
> --
> 1.8.2.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists