linux-kernel - Re: [RFC PATCH 1/2] mm: vmscan: let any negative return value from shrinker mean error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130516004749.GD24635@dastard>
Date:	Thu, 16 May 2013 10:47:49 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Oskar Andero <oskar.andero@...ymobile.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Hugh Dickins <hughd@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Radovan Lekanovic <radovan.lekanovic@...ymobile.com>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [RFC PATCH 1/2] mm: vmscan: let any negative return value from
 shrinker mean error

On Mon, May 13, 2013 at 04:16:34PM +0200, Oskar Andero wrote:
> The shrinkers must return -1 to indicate that it is busy. Instead of
> relaying on magical numbers, let any negative value indicate error. This
> opens up for using the errno.h error codes in the shrinker
> implementations.

Just what is the shrinker infrastructure supposed to do with a
random error code?

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/