linux-kernel - Re: [PATCH] ARM: mach-moxart: platform port for MOXA ART SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACmBeS3JZ8bm6jJbmrKTfmZqshezN6QKdmyPCKdQ2HUwzY7ggA@mail.gmail.com>
Date:	Thu, 16 May 2013 15:37:16 +0200
From:	Jonas Jensen <jonas.jensen@...il.com>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Arnd Bergmann <arnd@...db.de>, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: mach-moxart: platform port for MOXA ART SoC

On 15 May 2013 15:16, Arnd Bergmann <arnd@...db.de> wrote:
> The part that I don't understand at all is the "timer0" part. Is that a string
> from the data sheet?

I have next to no data sheets or documentation on the SoC itself. What
I know is from looking at old sources, which suggest there are more
than one timer (the rest were never implemented).

It only needs one for timer_tick? Does it make sense to just call it "timer"?

> Can you provide some more detail why what PMU registers are used here? Is that
> a "Performance Measurement Unit", "Power Management Unit" or something else?
> Are you sure that those registers are only ever needed for GPIO?

It's "Power Management Unit". The MMC driver uses it to read system
clock and write it to clock control, but I suspect it can be removed.
It's code under #ifdef MSD_SUPPORT_GET_CLOCK but I think the else is
perfectly acceptable.
GPIO uses it only to enable or disable pins.

>> diff --git a/arch/arm/mach-moxart/Makefile.boot
>> b/arch/arm/mach-moxart/Makefile.boot
>> new file mode 100644
>> index 0000000..760a0ef
>> --- /dev/null
>> +++ b/arch/arm/mach-moxart/Makefile.boot
>> @@ -0,0 +1,3 @@
>> +   zreladdr-y        += 0x00008000
>> +params_phys-y        := 0x00000100
>> +initrd_phys-y        := 0x00800000
>
> Is this still used?

Looks like this is no longer needed. Boots without it. Removed.

> You can leave out moxart_init() now, it's the default implementation.
> moxart_init_irq, moxart_handle_irq and nr_irqs should be obsolete if
> you did the irqchip driver correctly, same for moxart_timer_init and
> the clocksource driver.
>
> I think the only part remaining here is moxart_restart, but that is
> broken as long as reg_wdt does not get initialized. I think you could
> move that function into the watchdog driver and assign it to
> arm_pm_restart when you add that driver.

All removed. It boots after some additions to clocksource and irqchip.
arm_pm_restart is set in watchdog.


What I haven't commented on should already be fixed @
https://code.google.com/p/linux-3-10-rc1-moxart/

I'll send new patches.

Best regards,
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/