linux-kernel - Re: [PATCH, v2] ARM: omap2: gpmc: fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130516173923.GA5600@atomide.com>
Date:	Thu, 16 May 2013 10:39:24 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Vincent Stehlé <vincent.stehle@...oste.net>
Cc:	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vincent Stehlé <v-stehle@...com>,
	trivial@...nel.org
Subject: Re: [PATCH, v2] ARM: omap2: gpmc: fix compilation warning

* Vincent Stehlé <vincent.stehle@...oste.net> [130514 10:26]:
> From: Vincent Stehlé <v-stehle@...com>
> 
> Fix the following compilation warning:
> 
>   arch/arm/mach-omap2/gpmc.c: In function 'gpmc_probe_generic_child':
>   arch/arm/mach-omap2/gpmc.c:1477:4: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat]
> 
> Signed-off-by: Vincent Stehlé <v-stehle@...com>
> Cc: trivial@...nel.org
> ---
> 
> Tony wrote:
> > You should just change the format for dev_err instead of the casting.
> 
> Hi,
> 
> Sorry for the late answer; it seems this is a bit more complicated after all,
> as res.start can be 32b or 64b in LPAE. The common solution seems to be: cast
> to long long in all cases and print accordingly. Would you like this better?

Oh OK. In this case the GPMC is always within the 32-bit address space.

But considering that similar issue will be there for other code with
LPAE, how about add something generic to arch/arm/include/asm/io.h like:

#define PHYS_ADDR32(x)	((__force u32)(x))
#define PHYS_ADDR64(x)	((__force u64)(x))

Or maybe something like that already exists.

Regards,

Tony

>  arch/arm/mach-omap2/gpmc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 6c4da12..e74501e 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1473,8 +1473,8 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
>  	 */
>  	ret = gpmc_cs_remap(cs, res.start);
>  	if (ret < 0) {
> -		dev_err(&pdev->dev, "cannot remap GPMC CS %d to 0x%x\n",
> -			cs, res.start);
> +		dev_err(&pdev->dev, "cannot remap GPMC CS %d to 0x%llx\n",
> +			cs, (long long)res.start);
>  		goto err;
>  	}
>  
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/