linux-kernel - Re: Drop WARN on AMD lack of perfctrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130516181018.GO19669@dyad.programming.kicks-ass.net>
Date:	Thu, 16 May 2013 20:10:18 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Josh Boyer <jwboyer@...hat.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	x86@...nel.org, linux-kernel@...r.kernel.org, gleb@...hat.com,
	Robert Richter <rric@...nel.org>
Subject: Re: Drop WARN on AMD lack of perfctrs

On Thu, May 16, 2013 at 01:55:57PM -0400, Josh Boyer wrote:
> Maybe.  But do you really need to dump a stack trace here?  What is a
> user supposed to do with that information?  Can they fix the kernel?
> Can the fix the CPU?  As far as I can tell, they can't do either.

Send their CPU back to AMD is I suppose the best they can do ;-)
 
> Is using pr_err with the same message really somehow worse than using
> WARN?

I would make it a FW_BUG as well. But yeah, I suppose that is a better option
than the WARN_ON. Unless Robert had a different reason...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/