linux-kernel - Re: [PATCH 03/10] usb: phy: ab8500-usb: add transceiver clock control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 May 2013 10:15:22 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Felipe Balbi <balbi@...com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Lee Jones <lee.jones@...aro.org>,
	Praveena Nadahally <praveen.nadahally@...ricsson.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Mian Yousaf Kaukab <mian.yousaf.kaukab@...ricsson.com>
Subject: Re: [PATCH 03/10] usb: phy: ab8500-usb: add transceiver clock control

On 15 May 2013 14:03, Fabio Baltieri <fabio.baltieri@...aro.org> wrote:
> From: Mian Yousaf Kaukab <mian.yousaf.kaukab@...ricsson.com>
>
> Add common clock support code for the ab8500-usb phy driver.
>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Acked-by: Maxime Coquelin <maxime.coquelin@...com>
> Signed-off-by: Mian Yousaf Kaukab <mian.yousaf.kaukab@...ricsson.com>
> Signed-off-by: Fabio Baltieri <fabio.baltieri@...aro.org>
> ---
>  drivers/usb/phy/phy-ab8500-usb.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c
> index b043faa..cc0d7e5 100644
> --- a/drivers/usb/phy/phy-ab8500-usb.c
> +++ b/drivers/usb/phy/phy-ab8500-usb.c
> @@ -29,6 +29,8 @@
>  #include <linux/notifier.h>
>  #include <linux/interrupt.h>
>  #include <linux/delay.h>
> +#include <linux/clk.h>
> +#include <linux/err.h>
>  #include <linux/mfd/abx500.h>
>  #include <linux/mfd/abx500/ab8500.h>
>  #include <linux/usb/musb-ux500.h>
> @@ -126,6 +128,7 @@ struct ab8500_usb {
>         unsigned vbus_draw;
>         struct work_struct phy_dis_work;
>         enum ab8500_usb_mode mode;
> +       struct clk *sysclk;
>         struct regulator *v_ape;
>         struct regulator *v_musb;
>         struct regulator *v_ulpi;
> @@ -252,6 +255,9 @@ static void ab8500_usb_phy_enable(struct ab8500_usb *ab, bool sel_host)
>         if (IS_ERR(ab->pinctrl))
>                 dev_err(ab->dev, "could not get/set default pinstate\n");
>
> +       if (clk_prepare_enable(ab->sysclk))
> +               dev_err(ab->dev, "can't prepare/enable clock\n");
> +
>         ab8500_usb_regulator_enable(ab);
>
>         abx500_mask_and_set_register_interruptible(ab->dev,
> @@ -274,6 +280,8 @@ static void ab8500_usb_phy_disable(struct ab8500_usb *ab, bool sel_host)
>         /* Needed to disable the phy.*/
>         ab8500_usb_wd_workaround(ab);
>
> +       clk_disable_unprepare(ab->sysclk);
> +
>         ab8500_usb_regulator_disable(ab);
>
>         if (!IS_ERR(ab->pinctrl)) {
> @@ -784,6 +792,12 @@ static int ab8500_usb_probe(struct platform_device *pdev)
>         if (err)
>                 return err;
>
> +       ab->sysclk = devm_clk_get(ab->dev, "sysclk");
> +       if (IS_ERR(ab->sysclk)) {
> +               dev_err(ab->dev, "Could not get sysclk.\n");
> +               return PTR_ERR(ab->sysclk);
> +       }
> +
>         err = ab8500_usb_irq_setup(pdev, ab);
>         if (err < 0)
>                 return err;
> --
> 1.8.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/