linux-kernel - Re: [PATCH 3/9] perf top: Get rid of *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130517142817.GD3848@krava.brq.redhat.com>
Date:	Fri, 17 May 2013 16:28:17 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 3/9] perf top: Get rid of *_threaded() functions

On Tue, May 14, 2013 at 11:09:01AM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
> 
> Those _threaded() functions are needed to make hist tree handling
> thread-safe, but AFAICS the only thing it does is forcing it to use
> the intermediate 'collapsed' tree.  It can be acheived by setting
> sort__need_collapse to 1 in cmd_top() so no need to keep those
> _threaded() variants.
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-top.c | 23 +++++++++++++----------
>  tools/perf/util/hist.c   | 44 ++++++--------------------------------------
>  tools/perf/util/hist.h   |  4 ----
>  3 files changed, 19 insertions(+), 52 deletions(-)

Acked-by: Jiri Olsa <jolsa@...hat.com>

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/