linux-kernel - Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368813500.2194.83.camel@joe-AO722>
Date:	Fri, 17 May 2013 10:58:20 -0700
From:	Joe Perches <joe@...ches.com>
To:	Leon Romanovsky <leon@...n.nu>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, sbkim73@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument

On Fri, 2013-05-17 at 20:50 +0300, Leon Romanovsky wrote:
> On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz <sameo@...ux.intel.com> wrote:
> > On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote:
> >> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
[]
> >> @@ -121,7 +121,7 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata(
[]
> >> -     pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
> >> +     pd = devm_kzalloc(dev, sizeof(struct sec_platform_data), GFP_KERNEL);
> > How is that fixing anything ?
> Technically you are right, this fix brings code to be align to common
> code convention and allows to automatic tools  correctly parse it.

Not really.
Common coding convention is actually the original code.

from: Documentation/CodingStyle:

		Chapter 14: Allocating memory
[]
The preferred form for passing a size of a struct is the following:

	p = kmalloc(sizeof(*p), ...);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/