linux-kernel - Re: [PATCH] drivers: mfd: tps65912: Convert to use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALq1K=KP4pADX89QJ3MJzaC+uTeEVOy7FUNikEnYddb0u-rihw@mail.gmail.com>
Date:	Fri, 17 May 2013 21:07:14 +0300
From:	Leon Romanovsky <leon@...n.nu>
To:	sameo@...ux.intel.com
Cc:	linux-kernel@...r.kernel.org, Leon Romanovsky <leon@...n.nu>
Subject: Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc

Hi Samuel,

On Wed, May 15, 2013 at 12:19 PM, Leon Romanovsky <leon@...n.nu> wrote:
> There is no need to call kfree while using devm_kzalloc,
> remove it from *_device_init function.
>
> Signed-off-by: Leon Romanovsky <leon@...n.nu>
> ---
>  drivers/mfd/tps65912-core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

To be honest the whole tps65912 looks strange to me.
For example,  kfree(tps65912) calls all over the code.

tps65912_i2c_probe allocates tps65912 struct, but tps65912_device_exit
releases it.


--
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | leon@...n.nu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/