linux-kernel - Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbZ4Wxx7qsyYOfFES-UpTTcRcfV6GZi-R8YmxhC-sLV8g@mail.gmail.com>
Date:	Sat, 18 May 2013 00:02:18 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>,
	Ola Lilja <ola.o.lilja@...ricsson.com>
Subject: Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

On Wed, May 8, 2013 at 5:48 PM, Fabio Baltieri
<fabio.baltieri@...aro.org> wrote:
> On Wed, May 08, 2013 at 03:29:38PM +0100, Mark Brown wrote:

>> It seems like the code is definitely buggy here but is this really all
>> that's buggy or is it just the symptom you happen to have seen?
>
> For the pinctrl code drop I still think that it should go, but really
> I leave the last word to LinusW as suggested.

Kill it then.

At the time the driver was upstreamed, it was using the old
nmk_config_pins() interface to switch the pins.

All I did was convert them to use pinctrl. See commit
08d98fe0e81cd9424ef2451ed13afe91a9a26f9f

If nobody knows why it was doing that in the first place, let's
just kill it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/