linux-kernel - Re: [PATCH] ASoC: max98090: request IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130520130113.GU1627@sirena.org.uk>
Date:	Mon, 20 May 2013 08:01:13 -0500
From:	Mark Brown <broonie@...nel.org>
To:	Andrew Bresticker <abrestic@...omium.org>
Cc:	alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Ralph Birt <ralph.birt@...imintegrated.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: max98090: request IRQF_ONESHOT interrupt

On Sun, May 19, 2013 at 10:58:07PM -0700, Andrew Bresticker wrote:
> request_threaded_irq() rejects calls which both do not specify a handler
> (indicating that the primary IRQ handler should be used) and do not set
> IRQF_ONESHOT because the combination is unsafe with level-triggered
> interrupts.  It is safe in this case, though, since max98090 IRQs are

Applied, thanks.  If request_threaded_irq() is rejecting these that's
not ideal - some threaded interrupts can only be generated from within
threaded context and therefore can't have primary handlers.  Unless it
only rejects in the case where the parent IRQ is a hard IRQ of course.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)