linux-kernel - Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1454213.B1kNpQ6JtX@avalon>
Date:	Mon, 20 May 2013 15:46:59 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Axel Lin <axel.lin@...ics.com>,
	Simon Horman <horms+renesas@...ge.net.au>
Cc:	Thierry Reding <thierry.reding@...onic-design.de>,
	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()

Hi Axel,

Thank you for the patch.

On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/pwm/pwm-renesas-tpu.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
> index 8e6d8d7..319a6fe 100644
> --- a/drivers/pwm/pwm-renesas-tpu.c
> +++ b/drivers/pwm/pwm-renesas-tpu.c
> @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
>  {
>  	struct tpu_device *tpu = platform_get_drvdata(pdev);
>  	unsigned int i;
> +	int ret;
> +
> +	ret = pwmchip_remove(&tpu->chip);
> +	if (ret)
> +		return ret;
> 
>  	for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
>  		struct tpu_pwm_device *pwm = &tpu->pwms[i];
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/