linux-kernel - Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable hardware"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 May 2013 18:43:46 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>, "Rafael J. Wysocki" <rjw@...k.pl>,
	x86@...nel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX
 capable hardware"

On Mon 20-05-13 08:58:55, H. Peter Anvin wrote:
> On 05/20/2013 08:03 AM, Michal Hocko wrote:
> > This reverts commit 78d77df71510a96e042de7ba6dbd7998103642cb because
> > it breaks resume from suspend to ram. Git bisect pointed to this patch
> > and the revert fixes the problem.
> > 
> > There are no error messages neither during suspend not on resume when
> > the machine simply starts booting as if it wasn't suspended in RAM at
> > all.
> 
> Machine details and configuration, please?

The configuration has been posted in the referenced thread:
https://lkml.org/lkml/2013/5/14/398

dmicode and lspci -vvv are attached. What else you would be interested
in?

> This is one of a series of
> extremely bizarre suspend to RAM failures we are trying to make sense
> of... in this case, it means that somehow switching from setting the NX
> bit conditionally to unconditionally somehow fixes suspend to RAM!

Yes I was really surprised when I bisected to the patch. I was wondering
how an init code could influence s2ram...

> 
> Needless to say, this is not just bizarre, this is extremely disturbing.
> 
> 	-hpa
> 
> 

-- 
Michal Hocko
SUSE Labs

View attachment "dmidecode" of type "text/plain" (28506 bytes)

View attachment "lspci" of type "text/plain" (28837 bytes)