linux-kernel - Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable hardware"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519A6BC7.7060902@linux.intel.com>
Date:	Mon, 20 May 2013 11:30:31 -0700
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	Michal Hocko <mhocko@...e.cz>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>, "Rafael J. Wysocki" <rjw@...k.pl>,
	the arch/x86 maintainers <x86@...nel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable
 hardware"

On 05/20/2013 11:23 AM, Michal Hocko wrote:
> On Mon 20-05-13 10:21:09, Linus Torvalds wrote:
>> On Mon, May 20, 2013 at 9:43 AM, Michal Hocko <mhocko@...e.cz> wrote:
>>>
>>> The configuration has been posted in the referenced thread:
>>> https://lkml.org/lkml/2013/5/14/398
>>
>> Hmm. That's a regular intel i5 Sandybridge CPU. Which certainly has NX.
>>
>> Hmm. secondary_startup_64 isn't __initcode, is it? I think it's used
>> for resuming the other CPU's too and for CPU hotplug. Yes/no?
>>
>> If so early_pmd_flags shouldn't be __initdata, I think.
>>
>> Michal, does it work if you don't do the revert, but just remove the
>> __initdata instead?
> 
> Right you are! The following patch on top of your tree fixes the
> problem. Thanks a lot. I will leave the proper changelog to somebody who
> is more familiar with the area but AFAIU the real problem is that
> early_pmd_flags is no longer available beacause the section is gone.
> 

I'll write it up and send a pull request to Linus.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/