linux-kernel - Re: [PATCH] video/matrox/matroxfb_maven: Use module_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130520214206.078bc580@endymion.delvare>
Date:	Mon, 20 May 2013 21:42:06 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Peter Huewe <peterhuewe@....de>
Cc:	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video/matrox/matroxfb_maven: Use module_i2c_driver to
 register driver

On Mon, 20 May 2013 21:36:18 +0200, Peter Huewe wrote:
> Removing some boilerplate by using module_i2c_driver instead of calling
> register and unregister in the otherwise empty init/exit functions
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
>  drivers/video/matrox/matroxfb_maven.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
> index 217678e..fd4b64e 100644
> --- a/drivers/video/matrox/matroxfb_maven.c
> +++ b/drivers/video/matrox/matroxfb_maven.c
> @@ -1283,19 +1283,8 @@ static struct i2c_driver maven_driver={
>  	.id_table	= maven_id,
>  };
>  
> -static int __init matroxfb_maven_init(void)
> -{
> -	return i2c_add_driver(&maven_driver);
> -}
> -
> -static void __exit matroxfb_maven_exit(void)
> -{
> -	i2c_del_driver(&maven_driver);
> -}
> -
> +module_i2c_driver(maven_driver);
>  MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec <vandrove@...cvut.cz>");
>  MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver");
>  MODULE_LICENSE("GPL");
> -module_init(matroxfb_maven_init);
> -module_exit(matroxfb_maven_exit);
>  /* we do not have __setup() yet */

This last comment could certainly go away as well, AFAICT it's a now
meaningless relic.

Other than this:

Reviewed-by: Jean Delvare <khali@...ux-fr.org>

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/