linux-kernel - Re: [PATCH 3/5] partitions/msdos: enumerate also AIX LVM partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130520164152.9148828cc29fab3d3d02be23@linux-foundation.org>
Date:	Mon, 20 May 2013 16:41:52 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Philippe De Muyter <phdm@...qel.be>
Cc:	linux-kernel@...r.kernel.org, Karel Zak <kzak@...hat.com>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 3/5] partitions/msdos: enumerate also AIX LVM partitions

On Mon, 29 Apr 2013 23:18:31 +0200 Philippe De Muyter <phdm@...qel.be> wrote:

> Graft AIX partitions enumeration in partitions/msdos.c
> 
> There is already a AIX disks detection logic in msdos.c.  When an
> AIX disk has been found, and if configured to, call the aix partitions
> recognizer.  This avoids removal of AIX disks protection from msdos.c,
> avoids code duplication, and ensures that AIX partitions enumeration
> is called before plain msdos partitions enumeration.
> 
> ...
>
> --- a/block/partitions/msdos.c
> +++ b/block/partitions/msdos.c
> @@ -23,6 +23,7 @@
>  #include "check.h"
>  #include "msdos.h"
>  #include "efi.h"
> +#include "aix.h"
>  
>  /*
>   * Many architectures don't like unaligned accesses, while
> @@ -462,8 +463,12 @@ int msdos_partition(struct parsed_partitions *state)
>  	 */
>  	if (aix_magic_present(state, data)) {
>  		put_dev_sector(sect);
> +#ifdef CONFIG_AIX_PARTITION
> +		return aix_partition(state);
> +#else
>  		strlcat(state->pp_buf, " [AIX]", PAGE_SIZE);
>  		return 0;
> +#endif
>  	}
>  
>  	if (!msdos_magic_present(data + 510)) {

hm, what's going on here.

Why does partitions/msdos.c know about AIX at all?  Is there something
special about AIX partitioning which ties it in with msdos?

Now that we have AIX partitioning support, can we simply remove the AIX
code from msdos.c?  So msdos.c will say "I don't know what that is",
and we fall through to aix.c which says "that's mine!"?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/