linux-kernel - Re: [PATCH] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 May 2013 10:18:02 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Axel Lin <axel.lin@...ics.com>,
	Thierry Reding <thierry.reding@...onic-design.de>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: renesas-tpu: Add missing pwmchip_remove() call in
 tpu_remove()

On Sun, May 19, 2013 at 04:22:21PM +0200, Laurent Pinchart wrote:
> Hi Axel,
> 
> Thank you for the patch.
> 
> On Sunday 19 May 2013 13:45:31 Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@...ics.com>
> > ---
> >  drivers/pwm/pwm-renesas-tpu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
> > index 8e6d8d7..351addd 100644
> > --- a/drivers/pwm/pwm-renesas-tpu.c
> > +++ b/drivers/pwm/pwm-renesas-tpu.c
> > @@ -444,7 +444,7 @@ static int tpu_remove(struct platform_device *pdev)
> > 
> >  	pm_runtime_disable(&pdev->dev);
> > 
> > -	return 0;
> > +	return pwmchip_remove(&tpu->chip);
> 
> Could you please move that line at the beginning of the function ? There would 
> be a race condition otherwise, as the user could reenable PWM between the 
> tpu_pwm_timer_stop() calls and the pwmchip_remove() call.
> 
> Apart from that, the patch looks good.

Also, could you please CC linux-sh@...r.kernel.org,
that will help me track the change through patchwork.

Thanks!

> 
> >  }
> > 
> >  static struct platform_driver tpu_driver = {
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/